Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EtienneBaudoux.DevToys version 1.0.1.0 #43996

Closed
wants to merge 2 commits into from
Closed

EtienneBaudoux.DevToys version 1.0.1.0 #43996

wants to merge 2 commits into from

Conversation

yoshiask
Copy link

@yoshiask yoshiask commented Jan 30, 2022 •
edited

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jan 30, 2022
@ghost
Copy link

ghost commented Jan 30, 2022

Hello @yoshiask,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 30, 2022
@yoshiask
Copy link
Author

Am I missing something here? I don't see any error messages in the pipeline, and it passes validation and installs correctly locally.
image
image

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 30, 2022
ItzLevvie
ItzLevvie suggested changes Jan 30, 2022
View reviewed changes
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This application requires Microsoft.UI.Xaml.2.6 which is not currently supported by Azure Pipelines.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 30, 2022
@yoshiask
Copy link
Author

This application requires Microsoft.UI.Xaml.2.6 which is not currently supported by Azure Pipelines.

So are packages with a dependency on WinUI 2.6 not allowed on WinGet?

@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Jan 30, 2022
ItzLevvie
ItzLevvie suggested changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are packages with a dependency on WinUI 2.6 not allowed on WinGet?

At the moment, no.

Validation Pipelines are run against Microsoft Azure VMs on Windows 10 which comes pre-installed with WinUI 2.4 out-of-the-box and not WinUI 2.5, 2.6 or 2.7.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Feb 1, 2022
@yoshiask yoshiask mentioned this pull request Feb 2, 2022
Closed
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Feb 8, 2022
@ghost

This comment was marked as outdated.

Sign in to view
@ghost ghost removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Feb 8, 2022
@denelon denelon added Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 12, 2022
@Trenly
Copy link
Contributor

Trenly commented Mar 11, 2022

@denelon - Just curious as to when the pipelines will be upgraded to support the latest release of the client, which would unblock this PR

@denelon
Copy link
Contributor

denelon commented Mar 11, 2022

/azp run

@ghost ghost removed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Mar 11, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@denelon
Copy link
Contributor

denelon commented Mar 11, 2022

@Trenly, I'm watching the rollout of the 1.2 client. I'd like to get to a higher percentage of users with the latest client. The team has been discussing what target % makes sense.

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Mar 11, 2022
@ghost
Copy link

ghost commented Mar 11, 2022

Hello @yoshiask,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Mar 11, 2022
@jedieaston
Copy link
Contributor

Mildly off topic, but @denelon do you know if users will eventually get an update to winget (or for that matter, any Microsoft Store apps) even if they don't open the store? I'm guessing that most people don't open it that often, especially if they think Windows Update should be getting all their updates for Windows anyway.

@denelon
Copy link
Contributor

denelon commented Mar 11, 2022

@jedieaston the default Windows behavior does fetch updates in the background if they are not disabled.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 11, 2022
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Mar 18, 2022
@ghost
Copy link

ghost commented Mar 18, 2022

Hello @yoshiask,
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@yoshiask
Copy link
Author

What am I supposed to do here?

@ItzLevvie
Copy link
Contributor

ItzLevvie commented Mar 18, 2022 •
edited

cc @denelon: Would you be able to remove the Needs-Author-Feedback label from this PR?

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Mar 18, 2022
@denelon denelon removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 18, 2022
@denelon
Copy link
Contributor

denelon commented Mar 18, 2022

I believe 1.2 has had sufficient coverage from a "roll-out" perspective. We're catching up from the issue related to hitting all the rate limits on open PRs. I'll check with the team if we're using 1.2 in our validation environment so we can kick this one off again.

@dongle-the-gadget
Copy link
Contributor

Does Winget support .appinstaller files?

@denelon
Copy link
Contributor

denelon commented Jun 3, 2022

Does Winget support .appinstaller files?

In what context? We support the MSIX package format. We have both MSIX and Appx as supported installer types

@denelon
Copy link
Contributor

denelon commented Jul 20, 2022

/azp run

@ghost ghost removed the Validation-Installation-Error Error installing application label Jul 20, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jul 20, 2022
@ghost
Copy link

ghost commented Jul 20, 2022

Hello @yoshiask,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 20, 2022
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jul 27, 2022
@ghost
Copy link

ghost commented Jul 27, 2022

Hello @yoshiask,
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

@ghost ghost closed this Aug 3, 2022
@veler veler mentioned this pull request Dec 31, 2022
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Installation-Error Error installing application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yoshiask @wingetbot @Trenly @denelon @jedieaston @ItzLevvie @dongle-the-gadget