Avoid transmute for binding primitive argument types
#1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Jul 14, 2022
| @@ -1158,6 +1158,9 @@ impl<'a> Reader<'a> { | |||
| pub fn signature_param_is_convertible(&self, param: &SignatureParam) -> bool { | |||
| self.signature_param_maybe_generic(param) && self.type_is_convertible(¶m.ty) | |||
| } | |||
| pub fn signature_param_is_primitive(&self, param: &SignatureParam) -> bool { | |||
| self.signature_param_maybe_generic(param) && self.type_is_primitive(¶m.ty) | |||
There was a problem hiding this comment.
It feels like the name signature_param_maybe_generic is wrong now. I'm not sure exactly what it represents. It's an input param that's not a pointer, not a winrt array, and has no array info. How do we succinctly describe that?
There was a problem hiding this comment.
Yep those names don't make sense to me. I'm slowly making my way to these inner helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that signature types are categorized more clearly, we can remove the use of
transmutefor primitive types.