Adopt registerWorkbenchContribution2 for welcome page #204440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhavyaus thanks! This should be good to go: the editor resolver code still needs to run very early to register the editor. Only the |
bhavyaus
force-pushed
the
dev/bhavyau/welcome-page
branch
from
ff3f265
to
a64bdce
Compare
bhavyaus
force-pushed
the
dev/bhavyau/welcome-page
branch
from
f98251c
to
398c095
Compare
bpasero
approved these changes
Feb 6, 2024
bpasero
requested changes
Feb 6, 2024
|
@bhavyaus with my commit, it should work. the editor resolver needs to be there on startup for the editor to actually load. |
bpasero
requested changes
Feb 6, 2024
src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.contribution.ts
Outdated
Show resolved
Hide resolved
bpasero
requested changes
Feb 6, 2024
src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.contribution.ts
Show resolved
Hide resolved
bpasero
approved these changes
Feb 6, 2024
aiday-mar
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes: #193623
There are two scenarios to consider here for the GettingStartedInput editor type:
The startup editor (welcome page) is opened automatically if workbench.startupEditor setting is enabled by the user or on first launch for new users.
OpenWalkthrough command is invoked on Activation as described by the user here
onStartupFinishedactivation event has no criteria for startup finishing #193623StartupPageRunnerContributionwithWorkbenchPhase.AfterRestoredsupports Scenario 1StartupPageEditorResolverContributionwithWorkbenchPhase.BlockRestoresupports Scenario 2 by ensuring the editorResolver has time to register the input type.