Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug with nodemon,when close vscode,nodemon still running #72312

Closed
lerit opened this issue Apr 15, 2019 · 5 comments
Closed

debug with nodemon,when close vscode,nodemon still running #72312

lerit opened this issue Apr 15, 2019 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)

Comments

@lerit
Copy link

lerit commented Apr 15, 2019

  • VSCode Version:1.32.3
  • OS Version:ubuntu 18.04

Steps to Reproduce:

1.set launch.json to debug nodejs with nodemon
launch.json:

    {
      "name": "Node Debug",
      "type": "node",
      "request": "launch",
      "protocol": "inspector",
      "runtimeExecutable": "${workspaceRoot}/node_modules/.bin/nodemon",
      "args": [
        "--config",
        "${workspaceRoot}/nodemon.json",
        "dist/server/index.js"
      ],
      "sourceMaps": true,
      "restart": true,
      "console": "integratedTerminal", 
      "timeout": 15000,
      "internalConsoleOptions": "neverOpen",
      "skipFiles": ["<node_internals>/**", "node_modules/**"],
      "smartStep": true
    }

nodemon.json

{
  "verbose": true,
  "execMap": {
    "js": "node --harmony --trace-warnings"
  },
  "env": {
    "NODE_ENV": "development"
  },
  "watch": ["dist/server/index.js", "config"],
  "script": "dist/server/index.js"
}

2.press f5 to start debug
3.close vscode
4.when vscode close,i am sure that nodemon still running and start a new nodejs instance(by use command:top ,a new process named node start with high cpu 100%),i can only close this node process withcommand: pkill node

Does this issue occur when all extensions are disabled?: Yes

can vscode kill runtimeExecutable when it close,or can i use other methods to kill nodemon?

@lerit lerit changed the title debug with nodemon,when close vscode,nodemon continue run debug with nodemon,when close vscode,nodemon still run Apr 15, 2019
@lerit lerit changed the title debug with nodemon,when close vscode,nodemon still run debug with nodemon,when close vscode,nodemon still running Apr 15, 2019
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Apr 15, 2019
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Oct 16, 2019
@lerit
Copy link
Author

lerit commented May 13, 2020

still a problem,i think because runtimeExecutable can not be kill when close vscode or stop debug
@weinand
is this any method to stop runtimeExecutable program?

@lerit
Copy link
Author

lerit commented May 13, 2020

i think same issue #87321

@faabiopontes
Copy link

It just happened to me.. I can't believe VS Code doesn't close it's terminal after closing the program

@connor4312
Copy link
Member

Should be fixed with #108289

/duplicate

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants
@weinand @faabiopontes @connor4312 @lerit and others