Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js preview doesn't kill the process when the debugging is stopped #108289

Closed
agrawalsourav98 opened this issue Oct 8, 2020 · 4 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@agrawalsourav98
Copy link

Issue Type: Bug

I am using the Node.js preview for debugging my application. It uses a npm script. I select the script from the provided options suring setup of Node.js preview debugger.

The debugging has no issues but when i stop the debugger, the program running is not killed.

For instance, if i mounted my server on port 5000 previously, the port is still occuppied as the program is not killed. I have verified this through the netstat command.

VS Code version: Code 1.49.3 (2af0510, 2020-10-02T17:56:11.027Z)
OS version: Linux x64 5.4.0-48-generic

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2107)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: enabled_on
video_decode: unavailable_off
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 2, 1, 1
Memory (System) 11.54GB (5.29GB free)
Process Argv --no-sandbox --unity-launch
Screen Reader no
VM 0%
DESKTOP_SESSION pantheon
XDG_CURRENT_DESKTOP Unity
XDG_SESSION_DESKTOP pantheon
XDG_SESSION_TYPE x11
Extensions (3)
Extension Author (truncated) Version
vscode-eslint dba 2.1.8
prettier-vscode esb 5.7.1
python ms- 2020.9.114305
@connor4312
Copy link
Member

/jsDebugLogs

@connor4312 connor4312 added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 8, 2020
@connor4312
Copy link
Member

connor4312 commented Oct 13, 2020

Thanks for the issue, this'll be fixed in the next nightly build with microsoft/vscode-js-debug@5375f57

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Oct 13, 2020
@connor4312 connor4312 added this to the October 2020 milestone Oct 13, 2020
@aeschli
Copy link
Contributor

aeschli commented Oct 29, 2020

I verified by creating a Launch via NPM launch config that starts a long running node script. Stopping the launch also killed the process. @connor4312 Please let me know if more is needed

@aeschli aeschli added the verified Verification succeeded label Oct 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@connor4312 @aeschli @agrawalsourav98 and others