Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrated terminal: cursor blinking dosen't work with render type dom #70749

Closed
yukulele opened this issue Mar 19, 2019 · 2 comments · Fixed by #73599
Closed

integrated terminal: cursor blinking dosen't work with render type dom #70749

yukulele opened this issue Mar 19, 2019 · 2 comments · Fixed by #73599
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
May 2019

Comments

@yukulele
Copy link

yukulele commented Mar 19, 2019 •
edited
Loading

  • VSCode Version: 1.32.3
  • OS Version: ubuntu 18.04

Steps to Reproduce:

  1. use that in settings
{
  "terminal.integrated.cursorBlinking": true,
  "terminal.integrated.rendererType": "dom"
}
  1. open integrated terminal

→ cursor is not blinking

Does this issue occur when all extensions are disabled?: Yes
@vscodebot vscodebot bot removed the new release label Mar 19, 2019
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal Integrated terminal issues labels Mar 23, 2019
@Tyriar Tyriar mentioned this issue Mar 23, 2019
Closed
@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2019

Upstream issue: xtermjs/xterm.js#1977

@Tyriar Tyriar added good first issue Issues identified as good for first-time contributors help translation Issues related to translation - translation help wanted labels Mar 23, 2019
@Tyriar Tyriar added this to the Backlog milestone Mar 23, 2019
@roottool roottool mentioned this issue May 6, 2019
Closed
@roottool
Copy link

roottool commented May 6, 2019

I'm trying to resolve this issue.
My recognition is that this issue resolves by updating vscode-xterm using xtermjs/xterm.js#1979 and xtermjs/xterm.js#2039.

I created microsoft/xterm.js#1 which is PR to update vscode-xterm.
@Tyriar, please check it when you have time.

@Tyriar Tyriar removed good first issue Issues identified as good for first-time contributors help translation Issues related to translation - translation help wanted labels May 10, 2019
@Tyriar Tyriar modified the milestones: Backlog, May 2019 May 10, 2019
@Tyriar Tyriar mentioned this issue May 13, 2019
Merged
10 tasks
@mjbvz mjbvz added the verified Verification succeeded label May 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
May 2019
Development

Successfully merging a pull request may close this issue.

Update vscode-xterm microsoft/vscode
4 participants
@yukulele @Tyriar @roottool @mjbvz