Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folding No Longer Working #47454

Closed
iohcidnal opened this issue Apr 9, 2018 · 8 comments
Closed

Folding No Longer Working #47454

iohcidnal opened this issue Apr 9, 2018 · 8 comments
Assignees
Labels
editor-folding Editor code folding issues javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@iohcidnal
Copy link

iohcidnal commented Apr 9, 2018

Issue Type: Bug

Opening a React js file no longer displays folding controls on mouse hover in the render() function for components. For example:

      <PageHeader title="Log in"   // this does not show the fold control
        {...{  // this one does
          item: true,
          xs: 9,
          md: 5
        }}
      />

VS Code version: Code 1.22.1 (950b8b0, 2018-04-06T00:21:13.607Z)
OS version: Darwin x64 17.4.0

Extensions (27)
Extension Author (truncated) Version
bracket-pair-colorizer Coe 1.0.27
vscode-jest Ort 2.6.4
vscode-docker Pet 0.0.26
quokka-vscode Wal 1.0.117
html-css-class-completion Zig 1.17.1
html-snippets abu 0.2.1
react-pure-to-class-vscode ang 1.1.4
cake-vscode cak 0.10.1
jsrefactor cms 2.11.6
vscode-eslint dba 1.4.8
gitlens eam 8.2.0
tslint eg2 1.0.28
auto-close-tag for 0.5.6
auto-rename-tag for 0.0.15
csharpextensions jch 1.3.0
sharppad jma 1.0.5
mssql ms- 1.3.0
azure-account ms- 0.4.0
csharp ms- 1.14.0
PowerShell ms- 1.6.0
debugger-for-chrome msj 4.3.0
syncing non 1.5.3
convert-css-in-js pau 1.0.0
vscode-icons rob 7.22.0
guides spy 0.9.1
vscode-todo-highlight way 0.5.12
JavaScriptSnippets xab 1.5.0
@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Apr 9, 2018
@hideInbush
Copy link

hideInbush commented Apr 9, 2018

so do i... @btkfrank thanks. it did work

@btkfrank
Copy link

btkfrank commented Apr 9, 2018

same here in the recent update

@btkfrank
Copy link

btkfrank commented Apr 9, 2018

https://github.com/Microsoft/vscode/issues/46989
This works for me

@iohcidnal
Copy link
Author

@btkfrank I'm getting 404 from the link you posted.

@chatdanai
Copy link

Same on my machine, OSX. It's no longer work in JSX section. typescript section is fine.

@aeschli aeschli assigned mjbvz and unassigned aeschli Apr 9, 2018
@shobhitchittora
Copy link
Contributor

+1 on this. 👍🏻

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 9, 2018

Root caused by microsoft/TypeScript#23273

Will be fixed by #47473

@mjbvz mjbvz closed this as completed Apr 9, 2018
@mjbvz mjbvz added *duplicate Issue identified as a duplicate of another issue(s) upstream Issue identified as 'upstream' component related (exists outside of VS Code) typescript Typescript support issues javascript JavaScript support issues editor-folding Editor code folding issues and removed editor editor-contrib Editor collection of extras labels Apr 9, 2018
@btkfrank
Copy link

@iohcidnal for now you can temporarily add this to your user settings(cmd + ',' on mac)

"editor.foldingStrategy": "indentation"

Otherwise, wait for the new release

@vscodebot vscodebot bot locked and limited conversation to collaborators May 24, 2018
@mjbvz mjbvz added this to the July 2018 milestone Jul 9, 2018
@mjbvz mjbvz added verification-needed Verification of issue is requested and removed *duplicate Issue identified as a duplicate of another issue(s) labels Jul 9, 2018
@JacksonKearl JacksonKearl added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jul 31, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-folding Editor code folding issues javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants