Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for FileSearchProviderOptions.folderOptions.useIgnoreFiles are wrong #226736

Open
jrieken opened this issue Aug 27, 2024 · 0 comments
Open
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Aug 27, 2024

Testing #226668

The docs say "If set, {@link FileSearchProviderOptions.useIgnoreFiles.local} should also be true" which can be understood as "vscode gives you data but doesn't know the actual values". Given we control the data, we should enforce strictness and swap should with is.

@andreamah andreamah added search Search widget and operation issues bug Issue identified by VS Code Team member as probable bug labels Sep 3, 2024
@andreamah andreamah added this to the September 2024 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

2 participants