Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSearchProviderOptions isn't a good name for its purpose #226719

Open
jrieken opened this issue Aug 27, 2024 · 0 comments
Open

FileSearchProviderOptions isn't a good name for its purpose #226719

jrieken opened this issue Aug 27, 2024 · 0 comments
Assignees
@andreamah
Labels
polish Cleanup and polish issue search Search widget and operation issues
Milestone
October 2024

Comments

@jrieken
Copy link
Member

jrieken commented Aug 27, 2024

Testing #226668

The FileSearchProviderOptions options aren't options for the provider but for a single invocation of a provider, I believe the more correct name would be just FileSearchOptions
@andreamah andreamah added search Search widget and operation issues polish Cleanup and polish issue labels Sep 3, 2024
@andreamah andreamah added this to the September 2024 milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreamah andreamah

Labels
polish Cleanup and polish issue search Search widget and operation issues
Projects
None yet
Milestone
October 2024
Development

No branches or pull requests
2 participants
@jrieken @andreamah