Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Notebook Multi-Cell Commenting #223152

Closed
2 tasks done
Yoyokrazy opened this issue Jul 22, 2024 · 0 comments
Closed
2 tasks done

Test: Notebook Multi-Cell Commenting #223152

Yoyokrazy opened this issue Jul 22, 2024 · 0 comments

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Jul 22, 2024

Refs: #142437

Complexity: 3

author: @Yoyokrazy

Create Issue


Summary

Notebooks now support multi cell commenting. This is accomplished via cell multi-select and triggering a LineCommentCommand for the entire cell's range. Currently this uses the Toggle behavior for the comment, using the pre-existing heuristics that all standard code editors use.

Steps to Test:

  • Open a notebook containing cells of various languages and editing states
  • Use cell multiselect via ctrl+click or shift+click to select various cell ranges (including only a single cell)
  • Use ctrl+/ to trigger a comment for these selected cells

Things to look for:

  • cells are toggling their comments as expected (it should mirror what happens to the same code if it was in it's own standard code editor. ie a python cell vs the same code in a .py file, etc)
  • no keybindings are broken (make sure normal multiline commenting works as expected within cells
  • nothing happens to cells not in an editing state

Thanks for testing!

@vscodenpa vscodenpa added this to the July 2024 milestone Jul 22, 2024
@deepak1556 deepak1556 removed their assignment Jul 23, 2024
@kieferrm kieferrm removed their assignment Jul 23, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants