Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap Section Header Labels Are Really Hard To Read #209989

Closed
pouyakary opened this issue Apr 9, 2024 · 3 comments · Fixed by #209990
Closed

Minimap Section Header Labels Are Really Hard To Read #209989

pouyakary opened this issue Apr 9, 2024 · 3 comments · Fixed by #209990
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@pouyakary
Copy link
Contributor

pouyakary commented Apr 9, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.88.0
  • OS Version: Darwin arm64 23.0.0

The amazing work of @dgileadi on #190759 has been a wish come true for many of us. (Thanks a lot really!). In the past days trying to use it, I have noticed that it lacks readability a lot. I compared the feature to Xcode and what I saw was two things:

  1. Xcode's version has bolder font
  2. Xcode's version has letter spacing of around 1px

The combination of the two makes readability a lot more on Xcode's side on even smaller font sizes than of the vscode:

Screenshot 1403-01-21 at 11 46 01 PM

Thanks to the freshness of the feature, I could read the PR and develop both of them for vscode as well, which I will create as a PR right away:

@pouyakary
Copy link
Contributor Author

There are also other things, like configuring the color of the labels (which can also make them a lot readable and unreadable, and I'm going to fix them as well)

@pouyakary pouyakary changed the title Minimal Section Headers Are Really Hard To Read Minimap Section Header Labels Are Really Hard To Read Apr 9, 2024
@dimateos
Copy link

Not exactly related, as this issue targets the minimap view.

But we could also let the user configure the looks of the section markers in the editor:

image

I used a highlighter extension like https://marketplace.visualstudio.com/items?itemName=fabiospampinato.vscode-highlight (there are many similar)

I gave a custom style to the marker and the title. Also added custom gutter and scrollbar overview rulers (I can post the config, just ask)

Also if you note, I used two different markers to kind of specify hierarchy and matched them with different syles.
This styling could be potentially mixed with custom tags as in #209904, for example to achieve this hierarchy and also style customization.

Overall this marker hightlighting customization is similar to what existing extension do, but with built-in support (hence I hope better performance) and minimap renders.

Could open a separate issue, but seemed related and discussable here

@pouyakary
Copy link
Contributor Author

pouyakary commented Apr 11, 2024

@dimateos I agree that having in-editor decorations is also neccessary. But you should move the comment to a separate issue since it is a whole different topic. Aslo link it to #190759 or #74843

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label May 27, 2024
@vscodenpa vscodenpa added this to the May 2024 milestone May 27, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 28, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
4 participants