Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt ensureNoDisposablesAreLeakedInTestSuite in quickAccess.test.ts #204205

Open
TylerLeonhardt opened this issue Feb 2, 2024 · 0 comments
Open

Adopt ensureNoDisposablesAreLeakedInTestSuite in quickAccess.test.ts #204205

TylerLeonhardt opened this issue Feb 2, 2024 · 0 comments
Assignees
@TylerLeonhardt
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Milestone
Backlog

Comments

@TylerLeonhardt
Copy link
Member

Original issue: #200091

src/vs/workbench/test/browser/quickAccess.test.ts is a beast. It's gonna take me a some time to work through... mostly because a lot of the stuff was assumed to live on for the entire window, which makes sense given the area...

Opening this as a separate issue since it will take a fair amount of time.
@TylerLeonhardt TylerLeonhardt added debt Code quality issues engineering VS Code - Build / issue tracking / etc. labels Feb 2, 2024
@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone Feb 2, 2024
@TylerLeonhardt TylerLeonhardt self-assigned this Feb 2, 2024
@TylerLeonhardt TylerLeonhardt mentioned this issue Feb 2, 2024
Open
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@TylerLeonhardt