Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug Diagnostics text issue #195891

Closed
gaokun opened this issue Oct 18, 2023 · 1 comment · Fixed by microsoft/vscode-js-debug#1876
Closed

Debug Diagnostics text issue #195891

gaokun opened this issue Oct 18, 2023 · 1 comment · Fixed by microsoft/vscode-js-debug#1876
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues polish Cleanup and polish issue verified Verification succeeded
Milestone
November 2023

Comments

@gaokun
Copy link

gaokun commented Oct 18, 2023

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.83.1
  • OS Version: macOS 14.0

Steps to Reproduce:

I am developping an extension of vscode.

  1. Run Extension Debug

  2. mouse over on 'Unbound breakpoint'

  3. click toubleshoot
    image

  4. click "why my breakpoints don't bind"
    image

  5. then I can see below image

image

it is like a "diff result"
@roblourens roblourens assigned connor4312 and unassigned roblourens Oct 18, 2023
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues polish Cleanup and polish issue labels Oct 18, 2023
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue Nov 1, 2023
@connor4312
fix: path diff display in diagnostic tool
c4f51b9 
Fixes microsoft/vscode#195891
@connor4312 connor4312 mentioned this issue Nov 1, 2023
Merged
@connor4312 connor4312 added this to the November 2023 milestone Nov 30, 2023
@connor4312
Copy link
Member

Verification:

  • Have two JavaScript files, A and B, with the same name but in different paths/folders in your workspace
  • Set a breakpoint in file A
  • Debug file B. The breakpoint in A won't bind.
  • Run "Debug: Diagnose Breakpoint Problems" and follow the steps above. Verify the text diff only diffs full path segments and not substrings as shown in the original screenshots

@amunger amunger added the verified Verification succeeded label Nov 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

fix: path diff display in diagnostic tool microsoft/vscode-js-debug
4 participants
@roblourens @amunger @connor4312 @gaokun