inform screen reader of notebook inline suggestion

[meganrogge]

We should play an audio cue and will also want the screen reader to read the content immediately like we will do for the editor tracked by #167348

[meganrogge]

@rebornix @amunger what are your thoughts here/ has there been any headway made on this?

[amunger]

@meganrogge - I assume we should follow what we did for #167348, but it's hard to follow what the result was there. It looks like the last PR that was referenced was reverted, and I don't see the applicable code in the ghostTextWidget. Was there a final decision on behavior somewhere or a TPI? And is there another PR that I could use for reference?

[meganrogge]

Hi @amunger, we control the one in the editor with a setting. here's the implementation of that

vscode/src/vs/editor/contrib/inlineCompletions/browser/inlineCompletionsController.ts

Lines 236 to 238 in dcafd88

	if (this.editor.getOption(EditorOption.screenReaderAnnounceInlineSuggestion)) {
	this.provideScreenReaderUpdate(state.primaryGhostText.renderForScreenReader(lineText));
	}

[amunger]

the same code is hit for a notebook cell, the notification sound is played for me, and it looks like the aria alert is being added.

I don't ever hear any alert text on either of my machines and haven't been able to figure out why so I can't check, but is it not reading the ghost text for notebook cells?
Is there something else that's missing?

[meganrogge]

what is the value of lineText when that gets hit?

[meganrogge]

do you hear the alert when it's in the editor?

[amunger]

lineText is whatever else is on the line.
On my laptop the text editor ghost text is not read either.

I tried again on my desktop pc, and now the ghost text is read for both notebook cells and text editors. Are you seeing something different?

[meganrogge]

Sounds like an issue with the screen reader/ setup you have. I would suggest using the speech to text viewers rather than the audio version as then you won't wonder if it's an issue with your setup or the code.

[amunger]

speech viewer is what I'm using, I also checked the actual audio to make sure it wasn't there either

[amunger]

this appears to be working as intended