Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test comment filtering #158773

Closed
3 tasks done
alexr00 opened this issue Aug 22, 2022 · 3 comments
Closed
3 tasks done

Test comment filtering #158773

alexr00 opened this issue Aug 22, 2022 · 3 comments

Comments

@alexr00
Copy link
Member

alexr00 commented Aug 22, 2022

Refs: #150958

Complexity: 3

Create Issue


There's a new filter input box and menu in the Comments view. You can use GitHub Pull Requests and Issues (or a comment providing extension of your choice) to verify.

  1. Open a workspace with comments
    a. If you don't have one, you can use GitHub Pull Requests and Issues to open a pull request with comments
  2. Open the Comments view and verify the following:
  • that you can filter based on text in the body of the comment, including text that isn't visible in the comments view
  • that you can use usernames to filter
  • that you can filter by resolved/unresolved using the filter menu (note that not all extensions will support resolved/unresolved).
  • that the showing "x of y" text in the filter input box is always correct
  • that your filter state is preserved across reloads
@digitarald
Copy link
Contributor

Tested with #158313 which has 23 comments to search through.

@PabloLION
Copy link

Hi @digitarald . I'm with VS Code 1.71.0 on macOS. I saw the "comment filtering" in the release note but I cannot see it even with --disable-extensions flag.
image

Does it only work for PR? And if not, could you tell me where to enable it? I see here it's said "Open a workspace with comments". The comment filtering does work in a PR from GitHub extension for me

About VSCode Version: 1.71.0 Commit: 784b017 Date: 2022-09-01T07:25:25.516Z Electron: 19.0.12 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin arm64 21.3.0 Sandboxed: No

Thanks in advance.

@alexr00
Copy link
Member Author

alexr00 commented Sep 7, 2022

The "Comments" view is only available when there is an extension providing comments.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants