Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky line color contrast issue #156257

Closed
bpasero opened this issue Jul 26, 2022 · 2 comments
Closed

Sticky line color contrast issue #156257

bpasero opened this issue Jul 26, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jul 26, 2022

Testing #156175

I think the background color of the sticky lines has not sufficient color contrast to make it readable:

image

I suggest to connect with @misolori or @daviddossett for advice

@miguelsolorio
Copy link
Contributor

Have we considered using the editor bg color for this area, similar to the breadcrumbs? And that would make it easier to use existing hover styles like the list hover:

CleanShot.2022-07-26.at.08.55.12.mp4

I would just treat the sticky lines as an extension of the tab header area where the breadcrumbs area and if you can add a shadow on scroll (like breadcrumbs) that would be a nice touch:

CleanShot 2022-07-26 at 08 58 04@2x

@aiday-mar
Copy link
Contributor

Great thanks for the feedback I'll implement that!

@aiday-mar aiday-mar added the bug Issue identified by VS Code Team member as probable bug label Jul 27, 2022
@aiday-mar aiday-mar added this to the July 2022 milestone Jul 27, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 27, 2022
@lramos15 lramos15 added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants