Adopt argsCanBeInterpretedByShell for external terminals

[roblourens]

From #149910 and #149910

This is handled in a different way than for the integrated terminal - escaping never happened here...

[weinand]

@roblourens since the external terminals are platform (and terminal) specific, escaping (or quoting) is done in different ways.

On macOS the quoting is done in the iTerm and Terminal AppleScript helpers:

[roblourens]

I just realized that this code is for all external terminals, not debug specific, and escaping is all handled differently.

@Tyriar @meganrogge

• Linux and windows - do you want to use the more precise escaping from

  vscode/src/vs/workbench/contrib/debug/node/terminals.ts

  Line 164 in a951adf

  quote = (s: string) => {

  and

  vscode/src/vs/workbench/contrib/debug/node/terminals.ts

  Lines 123 to 131 in a951adf

  	quote = (s: string) => {
  	// Note: Wrapping in cmd /C "..." complicates the escaping.
  	// cmd /C "node -e "console.log(process.argv)" """A^>0"""" # prints "A>0"
  	// cmd /C "node -e "console.log(process.argv)" "foo^> bar"" # prints foo> bar
  	// Outside of the cmd /C, it could be a simple quoting, but here, the ^ is needed too
  	s = s.replace(/\"/g, '""');
  	s = s.replace(/([><!^&|])/g, '^$1');
  	return (' "'.split('').some(char => s.includes(char)) || s.length === 0) ? `"${s}"` : s;

  ? Currently the escaping for external terminals only looks for spaces in an arg. I could try to share this escaping function.
• Mac - whatever the applescript is doing for quoting is probably fine

[Tyriar]

@roblourens sounds good to me, I think debug may actually be the only consumer of runInTerminal in externalTerminal