Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor IntelliSense in debug console #153651

Closed
jrieken opened this issue Jun 29, 2022 · 2 comments · Fixed by microsoft/vscode-js-debug#1326
Closed

Poor IntelliSense in debug console #153651

jrieken opened this issue Jun 29, 2022 · 2 comments · Fixed by microsoft/vscode-js-debug#1326
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues papercut 🩸 A particularly annoying issue impacting someone on the team verified Verification succeeded
Milestone
July 2022

Comments

@jrieken
Copy link
Member

jrieken commented Jun 29, 2022

  • stop at a breakpoint
  • type the prefix of a variable in scope (suffi here)
  • quick suggest shows which is nice
  • hit escape
  • continue typing 🐛 no more quick suggest
  • manually trigger suggestion via ctrl+space: 🐛 no suggestions
Screen.Recording.2022-06-29.at.09.55.09.mov
@jrieken
Copy link
Member Author

jrieken commented Jun 29, 2022

My guess is that the completion item provider doesn't take the current prefix into account (when triggered). Let me know if you need consulting

@jrieken jrieken added the papercut 🩸 A particularly annoying issue impacting someone on the team label Jun 29, 2022
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jun 29, 2022
@roblourens
Copy link
Member

roblourens commented Jun 29, 2022 •
edited
Loading

It looks like vscode sends the right request but js-debug didn't return any completions

@roblourens roblourens reopened this Jun 29, 2022
@connor4312 connor4312 added this to the July 2022 milestone Jun 29, 2022
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue Jul 8, 2022
@connor4312
fix: completions not returning stack variables
f10c0e1 
We were just bailing out too soon. VS Code's behavior of reusing previous completions helped hide this bug.

Fixes microsoft/vscode#153651
@connor4312 connor4312 mentioned this issue Jul 8, 2022
Merged
@aiday-mar aiday-mar added the verified Verification succeeded label Jul 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues papercut 🩸 A particularly annoying issue impacting someone on the team verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

fix: completions not returning stack variables microsoft/vscode-js-debug
4 participants
@roblourens @jrieken @connor4312 @aiday-mar