Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The pseudoterminal extension API latency seems much higher than it was before #153182

Closed
Tyriar opened this issue Jun 25, 2022 · 3 comments · Fixed by #155452
Closed

The pseudoterminal extension API latency seems much higher than it was before #153182

Tyriar opened this issue Jun 25, 2022 · 3 comments · Fixed by #155452
Assignees
@deepak1556
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member extension-host Extension host issues important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Milestone
July 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2022

Not sure if something happened on the terminal or extension API but latency can easily hit 500ms+ on a keystroke which leads to a pretty bad experience.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug api terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. labels Jun 25, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 25, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jun 25, 2022 •
edited
Loading

@deepak1556 has something happened around message ports/ipc? This is super fast in v1.68 but very laggy in Insiders. The API allows extensions to create and control terminals, so it goes to the extension host instead of shared process->pty host.

To repro run this extension sample https://github.com/microsoft/vscode-extension-samples/tree/main/extension-terminal-sample and run the Extension Terminal Sample: Create command.

@deepak1556 deepak1556 added extension-host Extension host issues confirmed Issue has been confirmed by VS Code Team member sandbox Running VSCode in a node-free environment labels Jun 27, 2022
@deepak1556
Copy link
Collaborator

Can confirm the issue only happens with "extensions.experimental.useUtilityProcess": true

/cc @alexdima

@Tyriar Tyriar removed the api label Jun 27, 2022
@Tyriar Tyriar added the important Issue identified as high-priority label Jun 29, 2022
@deepak1556 deepak1556 modified the milestones: June 2022, July 2022 Jun 30, 2022
@Tyriar Tyriar mentioned this issue Jul 4, 2022
Closed
@joaomoreno joaomoreno mentioned this issue Jul 9, 2022
Closed
98 tasks
@deepak1556
Copy link
Collaborator

There was an issue in the timers interaction with event loop. Issue will be fixed in runtime tomorrow.

@deepak1556 deepak1556 mentioned this issue Jul 18, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 18, 2022
@connor4312 connor4312 added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member extension-host Extension host issues important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

chore: update electron@18.3.5 microsoft/vscode
5 participants
@deepak1556 @Tyriar @connor4312 @meganrogge @vscodenpa