Unbound breakpoint for TypeScript files

[sebastianrath]

Does this issue occur when all extensions are disabled?: Yes

I am building an Electron app, and the latest version of VScode stops binding breakpoints in TypeScript files. It is reproducible by switching between versions of VScode.

I also checked the latest Insider Build, with no success. Once I switch back to v1.66.2 it works.

Broken Version

Version: 1.67.0 (user setup)
Commit: 57fd6d0
Date: 2022-05-04T12:06:02.889Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Windows_NT x64 10.0.22610

Last Working Version

Version: 1.66.2 (user setup)
Commit: dfd34e8
Date: 2022-04-11T07:46:01.075Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Windows_NT x64 10.0.22610

The content of the launch.json is as follows:

    {
      "name": "Electron: Renderer",
      "type": "chrome",
      "request": "attach",
      "port": 9223,
      "sourceMaps": true,
      "webRoot": "${workspaceRoot}",
      "sourceMapPathOverrides": {
        "webpack:///./~/*": "${workspaceFolder}/node_modules/*",
        "webpack://?:*/*": "${workspaceFolder}/*"
      },
      "timeout": 300000
    },

[connor4312]

Please grab some log files!

/jsDebugLogs

[sebastianrath]

I'll send in the logs by email, but this log entry here stood out:

dap.receive

{
  "tag": "dap.receive",
  "timestamp": 1651845179436,
  "metadata": {
    "connectionId": 0,
    "message": {
      "command": "setBreakpoints",
      "arguments": {
        "source": {
          "name": "three.ts",
          "path": "c:\\Users\\sebastian\\Documents\\git\\foo\\src\\app\\viewer\\three\\three.ts"
        },
        "lines": [
          566
        ],
        "breakpoints": [
          {
            "line": 566
          }
        ],
        "sourceModified": false
      },
      "type": "request",
      "seq": 7
    }
  },
  "level": 0
}

dap.send

{
  "tag": "dap.send",
  "timestamp": 1651845179437,
  "metadata": {
    "connectionId": 0,
    "message": {
      "seq": 19,
      "type": "response",
      "request_seq": 7,
      "command": "setBreakpoints",
      "success": true,
      "body": {
        "breakpoints": [
          {
            "id": 1,
            "verified": false,
            "message": "Unbound breakpoint"
          }
        ]
      }
    }
  },
  "level": 0
}

[connor4312]

It doesn't look like I received anything, can you make sure it didn't bounce?

[sebastianrath]

Email sent. ✉️ 🚀

[connor4312]

Thanks for your help!

Over email we figured out it was because we made a change that added support for pathMapping sourcemaps. In this change, we preferentially loaded sourcemaps from the mapped URI, which is a file URI on disk. In this case, there actually was a sourcemap of the expected name on disk, which was not the version we would have preferred to load from the webpack-dev-server.

I will put in a PR to change the ordering back, which I think is fine, pathMapping of sourcemaps is only really useful if they don't exist at the original/intended location.

This issue may be candidate-worthy depending on whether we get more reports of it.

[sebastianrath]

Spot on help, thanks so much!