Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention default set of fileNesting patterns in setting description #145980

Closed
weinand opened this issue Mar 24, 2022 · 2 comments
Closed

Mention default set of fileNesting patterns in setting description #145980

weinand opened this issue Mar 24, 2022 · 2 comments
Assignees
Labels
file-explorer Explorer widget issues polish Cleanup and polish issue
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Mar 24, 2022

While verifying #142341 I was not aware of the fact that the setting "explorer.experimental.fileNesting.enabled": true comes with a full set of implicit default patterns even if no "explorer.experimental.fileNesting.patterns" exists in the settings.json. Only when modifying the default set, will the "explorer.experimental.fileNesting.patterns" setting show up.

CleanShot 2022-03-24 at 15 23 24@2x

The setting description need to make this clearer!

@JacksonKearl
Copy link
Contributor

This is roughly equivalent to what the file/search exclude already does today:
image

@JacksonKearl JacksonKearl added this to the Backlog milestone Apr 6, 2022
@JacksonKearl JacksonKearl added file-explorer Explorer widget issues polish Cleanup and polish issue labels Apr 6, 2022
@lramos15
Copy link
Member

Closing due to following other patterns. What specifically drove you to thinking they're examples maybe we could work on polishing the settings UI.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-explorer Explorer widget issues polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants