Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test tabs API #145585

Closed
3 tasks done
lramos15 opened this issue Mar 21, 2022 · 2 comments
Closed
3 tasks done

Test tabs API #145585

lramos15 opened this issue Mar 21, 2022 · 2 comments

Comments

@lramos15
Copy link
Member

lramos15 commented Mar 21, 2022

Refs: #133532

Complexity: 4

Create Issue


We are finalizing the shape of the tabs API and want feedback alongside bug testing .

	"enabledApiProposals": [
		"tabs"
	],

Some things to test

  • All the functions work as expected
  • Names and comments make sense
  • API feels easy to use and there are no major pain points

Additionally any general feedback regarding the API is greatly appreciated.!

@bpasero
Copy link
Member

bpasero commented Mar 22, 2022

If someone has the energy: would be nice to validate the API with an extension sample (https://github.com/microsoft/vscode-extension-samples), e.g. a custom tree view that re-implements the "Open Editors" view.

image

I could go on with testing because the API is quite complex and there are a lot of corner cases.

@lramos15
Copy link
Member Author

@bpasero Thanks for the testing :). I'll suggest it to Kai and SteVen as a possible candidate for the sample I do next iteration

@JacksonKearl JacksonKearl removed their assignment Mar 23, 2022
@joyceerhl joyceerhl removed their assignment Mar 23, 2022
@roblourens roblourens mentioned this issue Mar 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants