Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give lazy expand link a tooltip #143799

Closed
JacksonKearl opened this issue Feb 23, 2022 · 6 comments
Closed

Give lazy expand link a tooltip #143799

JacksonKearl opened this issue Feb 23, 2022 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@JacksonKearl
Copy link
Contributor

Testing #143572

Hovering the lazy expander (...) does not have a tooltip describing what the click will actually do

@roblourens
Copy link
Member

Any suggestions for what it should be? The placeholder value could go here.

cc @weinand @connor4312

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 23, 2022
@roblourens roblourens added this to the February 2022 milestone Feb 23, 2022
@connor4312
Copy link
Member

Something like Evaluate ${name}?

@weinand
Copy link
Contributor

weinand commented Feb 23, 2022

@connor4312 you said somewhere that "evaluate" is not the correct term. What does Chrome devtools do?

@connor4312
Copy link
Member

Chrome devtools is "Invoke Property Getter". Which is good but also somewhat language specific. Maybe Rob's suggestion of using the value is a good idea, js-debug could pass back a label like that. It would also look nice in UIs who haven't yet adopted the lazy flag.

@JacksonKearl
Copy link
Contributor Author

Resolve makes sense to me.

@roblourens
Copy link
Member

I want to start with the value, I think it will be more helpful. Let's see if that works in js-debug. Otherwise I would go with Resolve $name

@connor4312 connor4312 added the verified Verification succeeded label Feb 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @weinand @connor4312 @JacksonKearl and others