Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disassembly view: support keyboard navigation #129538

Open
isidorn opened this issue Jul 27, 2021 · 1 comment
Open

Disassembly view: support keyboard navigation #129538

isidorn opened this issue Jul 27, 2021 · 1 comment
Assignees
@roblourens
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly feature-request Request for new features or functionality
Milestone
Backlog

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 27, 2021

Testing #129161

@yuehuang010, @xisui-MSFT

  1. Open disassembly view, focus one of the items
  2. Start typing an address as a way to navigate to it -> nothing happens

I suggest to use the keyboardNavigationLabelProvider
Example https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/debug/browser/variablesView.ts#L128

That way it will make it possible for users to easily navigate the view by address
@isidorn isidorn added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 27, 2021
@xisui-MSFT
Copy link
Contributor

@yuehuang010 Will take a look

@weinand weinand removed their assignment Aug 18, 2021
@isidorn isidorn added this to the Backlog milestone Aug 26, 2021
@isidorn isidorn assigned roblourens and unassigned isidorn Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly feature-request Request for new features or functionality
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@roblourens @weinand @isidorn @xisui-MSFT