Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments API: group comments per tag in the Comments panel #127476

Closed
laurentlb opened this issue Jun 29, 2021 · 2 comments
Closed

Comments API: group comments per tag in the Comments panel #127476

laurentlb opened this issue Jun 29, 2021 · 2 comments
Assignees
@alexr00
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality info-needed Issue requires more information from poster

Comments

@laurentlb
Copy link
Contributor

I sometimes create multiple pull requests from the same workspace. In the comments panel, I will see the comments from all PRs. It would be nice if I could group the comments per PR in the comments panel. The typical use-case is that I want to resolve all related comments first.

In terms of API, we could imagine a new tag in the CommentThread object. Then the UI would offer a way to group comments using that tag.
@rebornix rebornix added feature-request Request for new features or functionality comments Comments Provider/Widget/Panel issues labels Jul 1, 2021
@rebornix rebornix removed their assignment Jul 1, 2021
@rebornix rebornix added this to the Backlog milestone Jul 1, 2021
@hermannloose hermannloose mentioned this issue Jun 22, 2022
Closed
@alexr00 alexr00 self-assigned this Jul 22, 2022
@alexr00
Copy link
Member

alexr00 commented Dec 5, 2022

I sometimes create multiple pull requests from the same workspace. In the comments panel, I will see the comments from all PRs.

This sounds like something the extension that contributes the comments might be able to handle. Is it possible that the extension could only provide the comments for 1 PR at a time?

@alexr00 alexr00 removed this from the Backlog milestone Dec 5, 2022
@alexr00 alexr00 added the info-needed Issue requires more information from poster label Dec 5, 2022
@laurentlb
Copy link
Contributor Author

This feature request is a bit old, and it hasn't been much of a problem until now. I think we can close it until we have a more specific need.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laurentlb @rebornix @alexr00