Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell running should use progress notifications in status bar #124193

Closed
isidorn opened this issue May 19, 2021 · 12 comments
Closed

Cell running should use progress notifications in status bar #124193

isidorn opened this issue May 19, 2021 · 12 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented May 19, 2021

Have a notebook with a lot of cells.
Scroll down to cell N#8 for example. Click on the Run all above cells button.
Now you are not aware of the progress of the above cells, you have to scroll up.

I suggest to use a progress notification in the status bar, that would say which cell is currently in progress. That way the user would be aware of what is going on without having to scroll down.

fyi @jrieken

@roblourens
Copy link
Member

You can have multiple cells in progress, do we list all of them?

@roblourens roblourens added the under-discussion Issue is under discussion for relevance, priority, approach label May 19, 2021
@isidorn
Copy link
Contributor Author

isidorn commented May 19, 2021

I suggest if there is just one mention the name. If there are multiple say "n cells in progress..." to not take too much status bar space.

@roblourens
Copy link
Member

I can keep this open but I don't think that notebook users are often concerned with tracking cell-by-cell execution progress.

@roblourens roblourens added this to the Backlog milestone May 19, 2021
@rebornix
Copy link
Member

My painpoint is always hard to find which cell is executing.

@miguelsolorio
Copy link
Contributor

There's #107919 that tracks the running of the active cell when executing Run All Cells

@isidorn
Copy link
Contributor Author

isidorn commented May 20, 2021

Well I am a notebook user, and I actually am puzzled when I run all above cells what is the progress, and is anything running at all? IMHO this is the only thing which the webview notebooks do better.

#107919 defeats the purpose of what I want as a user: that my screen view port does not change and that I am aware how is the execution above progressing

Without this feature clicking on run all above cells does not give any feedback to the user that anything is running at all

@miguelsolorio
Copy link
Contributor

IMO, I think adding an item in the status bar will work fine, similar to the running tasks.

@roblourens
Copy link
Member

What does the webview notebook do for this?

@isidorn
Copy link
Contributor Author

isidorn commented May 21, 2021

They show a sinner in the status bar with Executing Cell text

photo5852431753493460783

@roblourens
Copy link
Member

@digitarald also brought up the point of not being able to tell whether a collapsed cell is executing. Not sure I want to keep the cell status bar visible when a cell is collapsed, but we could have an item in the editor status bar (or notebook toolbar?) like @isidorn suggests, and if I click it, the top currently executing cell is focused/revealed.

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Jul 27, 2021

Just ran into this issue where I have a notebook with 142 cells and when I hit "running all" I wasn't sure where the current cell was without scrolling:

image

Would love it if we showed a status bar item with the spinner icon after a certain amount of time (10s?)

@roblourens
Copy link
Member

#130611

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants