Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't find the documentation about the codeActionsOnSave feature #104219

Closed
Luxcium opened this issue Aug 7, 2020 · 9 comments · Fixed by microsoft/vscode-docs#3938
Closed
Assignees
Labels
good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@Luxcium
Copy link

Luxcium commented Aug 7, 2020

I feel like I will create a duplicate but I know than @mjbvz will be able to point me to it so I can find the answer to my question unless I go on youtube and look at Matt videos... I mention that because I know indeed a video that would answer to my question but I would like to have the authoritative source...

How can I find the list of the vscode default behaviour for "editor.codeActionsOnSave": [/* ... */],
and is it possible to have an autocompletion in the near future?

I fell like a little more documentation should be available and I am not sure how to ask you that I know you are working hard to make it perfect and that maybe I should have searched more ...

@Luxcium Luxcium changed the title I canot find the documentation about the codeActionsOnSave feature I can't find the documentation about the codeActionsOnSave feature Aug 7, 2020
@Luxcium
Copy link
Author

Luxcium commented Aug 7, 2020

This is the video I was referring to... But I feel like I should be able to find that information from the vscode docs and I was unable to ... VS Code tips: Add missing imports on save for JavaScript and TypeScript by Matt Bierner on the Code 2020 Youtube channel (I was looking specifically for this before I wrote this GH issue "editor.codeActionsOnSave": [ "source.addMissingImports" ])

@mjbvz mjbvz added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Aug 7, 2020
@gunadhya
Copy link

Hi @mjbvz , I'd like to work on this.

@KDharmindar
Copy link

Hello @gunadhya have you been able to fix this? Are you working on this?

@gunadhya
Copy link

@KDharmindar Hi, yes I'm working on it.

So looking through the vscode-docs I was able to find codeActionsOnSave feature on this commit
and I confirmed it by going on the main site and found references to codeActionsOnSave here and here and some other places but I could not find missing imports and fixall on the docs but they do exist in the update releases page as referenced above.
So should I transfer those to the docs? And are any other changes needed ?

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 11, 2020

Yes, there should likely just be a new section in one of the docs pages for codeActionsOnSave. The fixes all come from extensions but we can document the couple of built-in ones

@gunadhya
Copy link

So should I add the codeActionOnSave documentation after this section on both javascript.md and typescript.md
vscode-docs or any other suggestions?

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 11, 2020

Sure, that sounds good

@Luxcium
Copy link
Author

Luxcium commented Aug 14, 2020

What about the fixes (or actions) that come from extensions? will it be possible to have support somehow in the JSON Validation (in settings.json file)? I mean I can look at the Feature Contribution of each of the installed extensions... At this moment I think only ESLint contributes (from my installed extensions) but I have 57 extensions installed and I would like to have a quick way to know what is possible to include in my codeActionsOnSave array... What should I expect? is it to the creator of the extension to implement something to make this work? because I already have support to find "eslint.codeActionsOnSave.mode" with the autocompletion system but not for "source.fixAll.eslint" in the "editor.codeActionsOnSave"

@Luxcium
Copy link
Author

Luxcium commented Aug 14, 2020

These settings are probably redundant I never noticed it before ...

@mjbvz mjbvz added this to the August 2020 milestone Aug 17, 2020
@mjbvz mjbvz added the upstream-issue-linked This is an upstream issue that has been reported upstream label Aug 17, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants