Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many Touch ID prompts when using SeKey and an SSH server #875

Closed
rgov opened this issue Jul 1, 2019 · 5 comments
Closed

Many Touch ID prompts when using SeKey and an SSH server #875

rgov opened this issue Jul 1, 2019 · 5 comments
Labels
feature-request Request for new features or functionality ssh Issue in vscode-remote SSH

Comments

@rgov
Copy link

rgov commented Jul 1, 2019

  • VSCode Version: 1.35.1
  • Local OS Version: macOS 10.15.6
  • Remote OS Version: Linux 3.10.0-693.2.2.el7.x86_64
  • Remote Extension/Connection Type: SSH

Steps to Reproduce:

  1. Install SeKey, a tool that stores SSH keys on the Secure Enclave on Touch ID-equipped Macs. Configure public key authentication to a remote SSH server using a key stored on the Secure Enclave.

  2. Use Visual Studio Code to connect to the Remote SSH server.

  3. During "Confirming is reachable" phase, authenticate via Touch ID. (Awesome that it works with no change on the VS Code side!)

  4. Authenticate via Touch ID again, during "Initializing VS Code Server" phase.

  5. Authenticate via Touch ID again, during "Waiting for port forwarding" phase.

  6. Click "Open Folder" in the file navigator and enter a path to open.

  7. Authenticate via Touch ID two more times...

Does this issue occur when you try this locally?: No
Does this issue occur when you try this locally and all extensions are disabled?: Yes

@rgov rgov changed the title Many TouchID prompts when using SeKey Many Touch ID prompts when using SeKey and an SSH server Jul 1, 2019
@roblourens
Copy link
Member

I would expect 3 auth steps (with nightly ssh, it will be 2). Then reloading the window there will be 2 more. Still working on this...

@roblourens roblourens added feature-request Request for new features or functionality ssh Issue in vscode-remote SSH labels Jul 1, 2019
@Chuxel
Copy link
Member

Chuxel commented Aug 29, 2019

@roblourens #96 (and thus the next release) should largely eliminate this problem correct?

@roblourens
Copy link
Member

Yes but I should test SeKey to make sure it still works when taking ssh out of the terminal.

@rgov
Copy link
Author

rgov commented Sep 16, 2019

This has gotten pretty good. Holding open per previous comment.

@roblourens
Copy link
Member

#96 should essentially fix this if you enable that option.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality ssh Issue in vscode-remote SSH
Projects
None yet
Development

No branches or pull requests

3 participants