Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use on runArgs in docker-compose interface #1299

Closed
Rhahkeem opened this issue Aug 28, 2019 · 7 comments
Closed

Allow use on runArgs in docker-compose interface #1299

Rhahkeem opened this issue Aug 28, 2019 · 7 comments
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality info-needed Issue requires more information from poster

Comments

@Rhahkeem
Copy link

Issue Type: Feature Request

In the docs for .devcontainer.json it shows that runArgs are an option when using a Dockerfile but not when using docker-compose.

Can this option also be extended to the docker-compose interface as it would allow for an easier transition when switching between the two and a more unified interface

Extension version: 0.67.3
VS Code version: Code 1.37.1 (f06011ac164ae4dc8e753a3fe7f9549844d15e35, 2019-08-15T16:16:34.800Z)
OS version: Darwin x64 18.6.0
Remote OS version: Linux x64 4.9.184-linuxkit

@chrmarti
Copy link
Contributor

chrmarti commented Sep 5, 2019

Most arguments to docker run are available as options in the docker-compose.yml, but not as docker-compose CLI arguments.

@chrmarti chrmarti added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels Sep 5, 2019
@Rhahkeem
Copy link
Author

Rhahkeem commented Sep 5, 2019

You can use them as arguments to docker-compose run which is what the extension runs if I understand correctly

@chrmarti
Copy link
Contributor

chrmarti commented Sep 6, 2019

We use docker-compose up to build and start all services. docker-compose run would have to be run for each service.

@Rhahkeem
Copy link
Author

Rhahkeem commented Sep 7, 2019

ahh

@Rhahkeem
Copy link
Author

Potentially docker-compose run can be used for the main service and up for the rest?

@chrmarti
Copy link
Contributor

Maybe what you want can be achieved by having multiple docker-compose.yml files? You can have a main one and then add to that with additional files. devcontainer.json allows you to specify multiple compose files (main one first).

@chrmarti chrmarti added the info-needed Issue requires more information from poster label Sep 20, 2019
@vscodebot vscodebot bot closed this as completed Sep 27, 2019
@vscodebot
Copy link

vscodebot bot commented Sep 27, 2019

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants