Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test connecting using local server to manage connection #1255

Closed
3 tasks done
roblourens opened this issue Aug 27, 2019 · 9 comments
Closed
3 tasks done

Test connecting using local server to manage connection #1255

roblourens opened this issue Aug 27, 2019 · 9 comments
Labels
testplan-item Test plan item/assignments for upcoming release
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Aug 27, 2019

Test #96

Complexity: 5

Install the nightly version of the extension (uninstall stable)

  • Set "remote.SSH.useLocalServer": true
  • Connect to an ssh host with password auth, e.g. https://github.com/microsoft/vscode-internalbacklog/issues/700
  • Reload the window
  • You should not have to enter your password again
  • This works by starting a local server to manage the ssh connection. In the Remote-SSH output channel log you can see Spawned 1234 when the server is started, and in an instance that connected to an already running server, you will see Found running server - short-circuiting install
  • Try opening multiple windows, reloading, make sure it works as expected. It's easiest to use password auth so its obvious that something went wrong if you have to enter your password again.
  • Close all windows - 3 minutes later, the server process should die.
@roblourens roblourens added the testplan-item Test plan item/assignments for upcoming release label Aug 27, 2019
@roblourens roblourens added this to the August 2019 milestone Aug 27, 2019
@jrieken
Copy link
Member

jrieken commented Aug 27, 2019

@roblourens The remote.SSH.useLocalServer -setting doesn't exists...

Screenshot 2019-08-27 at 11 15 39

@sandy081
Copy link
Member

Blocked because of #1269

@roblourens
Copy link
Member Author

It's an undocumented setting at the moment

@roblourens
Copy link
Member Author

It can still be tested with a VM that doesn't require a password, but fixing...

@jrieken
Copy link
Member

jrieken commented Aug 28, 2019

Confusion... Isn't this item about testing that password prompts only show once? So, when I have a VM that doesn't require a password how do I know that things are in order?

@roblourens
Copy link
Member Author

It's mostly testing that things still just work, but yeah testing the password auth flow is an important part of that. Anyway, the above issue is fixed now.

@roblourens
Copy link
Member Author

And @sbatten you can still hold off on windows testing.

@sbatten sbatten removed their assignment Aug 28, 2019
@sbatten
Copy link
Member

sbatten commented Aug 28, 2019

Please re-assign if this becomes ready

@roblourens
Copy link
Member Author

Not going to publicize it in release notes this month. There are some issues which you guys found, reconnection doesn't work as well as I thought, and windows is still currently a no-go. SSH on windows doesn't report the askpass prompt message. Meaning we can show a password prompt and complete the loop but we can't tell the user what we are asking for - password, key passphrase, 2fa key, etc.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item Test plan item/assignments for upcoming release
Projects
None yet
Development

No branches or pull requests

4 participants