Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exclude lists in a test run request #16929

Closed
karthiknadig opened this issue Aug 11, 2021 · 1 comment
Closed

Handle exclude lists in a test run request #16929

karthiknadig opened this issue Aug 11, 2021 · 1 comment
Assignees
Labels
area-testing bug Issue identified by VS Code Team member as probable bug

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Aug 11, 2021

See here for how exclude list is generated: microsoft/vscode#130522

  1. unittest: The underlying test adapter deals with testcases only. All we need to do is pass the right set of test case nodes (leaf nodes) to the runner in the extension.
  2. pytest : With the current test adapter we need to do additional work to prune the test tree to the a set of tests nodes that have no children in them that are in the exclude list. We can then pass the pruned nodes to the runner in the extension. A better approach here would be to update the test adapter to handle test runs based on the leaf nodes. This will also allow us to report test run progress, instead of running everything in bulk.
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug needs PR area-testing triage-needed Needs assignment to the proper sub-team labels Aug 11, 2021
@karthiknadig karthiknadig self-assigned this Aug 11, 2021
@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Aug 11, 2021
@karthiknadig karthiknadig removed their assignment Aug 11, 2021
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@eleanorjboyd eleanorjboyd self-assigned this Jul 14, 2023
@eleanorjboyd
Copy link
Member

Hello! I have reviewed this issue and given the architectural changes of the testing rewrite, this issue should no longer exist on the rewrite. Therefore I am going to close this issue but please comment or open a new issue if you are still seeing a problem when you try this yourself!

To use the rewrite yourself just add ”python.experiments.optInto": ["pythonTestAdapter"] to your user settings. You can confirm you have the rewrite enabled by setting your log level to trace, via the Developer: Set Log Level command in the command palette. Then check to see if Experiment 'pythonTestAdapter' is active is in your python logs.

Thanks!

@github-actions github-actions bot removed the needs PR Ready to be worked on label Oct 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants