Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding comment failure doesn't handle the error case correctly #919

Closed
Tyriar opened this issue Feb 5, 2019 · 2 comments
Closed

Adding comment failure doesn't handle the error case correctly #919

Tyriar opened this issue Feb 5, 2019 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 5, 2019

vscode: insiders 2019-02-05T10:03:57.911Z
ext version: 1.31.0
macOS

I don't know why this failed but this happens after hitting "Start review", you're not handling the error case correctly and reverting to the original start review/add comment buttons:

screen shot 2019-02-05 at 11 51 35 am
@Tyriar
Copy link
Member Author

Tyriar commented Feb 5, 2019

The error was fixed after I did a git pull in terminal, between these 2 commits in xtermjs/xterm.js#1878

screen shot 2019-02-05 at 11 58 25 am

@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Feb 7, 2019
@alexr00
Copy link
Member

alexr00 commented Nov 17, 2021

I'm not able to reproduce this.

@alexr00 alexr00 closed this as completed Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tyriar @RMacfarlane @alexr00