Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close multidiff editors when outdated #5761

Open
alexr00 opened this issue Feb 16, 2024 · 2 comments
Open

Close multidiff editors when outdated #5761

alexr00 opened this issue Feb 16, 2024 · 2 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug upstream/vscode
Milestone
On Deck

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 16, 2024

Opening the same PR again can result in outdated multidiff editors as the left can become out of date. These should be closed when the PR is opened.
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Feb 16, 2024
@alexr00 alexr00 added this to the February 2024 milestone Feb 16, 2024
@alexr00 alexr00 self-assigned this Feb 16, 2024
@alexr00 alexr00 modified the milestones: February 2024, March 2024 Feb 19, 2024
@alexr00 alexr00 mentioned this issue Feb 19, 2024
Closed
@alexr00 alexr00 modified the milestones: March 2024, On Deck Feb 28, 2024
@alexr00
Copy link
Member Author

alexr00 commented Feb 28, 2024

This requires some work in VS Code core to expose a TabInputMultiDiff type in the tabs API, otherwise an extension can't find which tab to close.

@alexr00
Copy link
Member Author

alexr00 commented Feb 28, 2024

Upstream issue: microsoft/vscode#206411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug upstream/vscode
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
1 participant
@alexr00