Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctl+F when used in SQL Server Object Explorer - the Filter option does not filter to found results #17539

Closed
whytheq opened this issue Feb 7, 2023 · 6 comments

Comments

@whytheq
Copy link

whytheq commented Feb 7, 2023

  • MSSQL Extension Version: 1.17.1
  • VSCode Version: 1.75.0
  • OS Version: Windows_NT x64 10.0.19045

Steps to Reproduce:

  1. Go to the SQL Server Object Explorer
  2. Expand "Databases" folder
  3. Expand specific database folder
  4. Expand views folder
  5. Press Ctrl+F
  6. Type a search string
  7. In the small Ctrl+F form select the 'Filter' button

At step 7, previously, the items in the tree would filter so only those found would be visible - now they do not filter and are simply highlighted. The above functionality still works for other extensions.

We have thousands of items in these object explorer folders, so this functionality is very useful.

@ibkhilji
Copy link

ibkhilji commented Mar 5, 2023

Yes i am also facing this issue

@kupdegrove
Copy link

This is apparently still a problem. I'm experiencing the same issue. It was working so I'm not sure what happened.

@Data-mite
Copy link

Also an issue here. Filtering seems unable to hide items which have items below them in hierarchy, so is not useful for tables, views, stored procedures, as each of these has components beneath them.

@Charles-Gagnon
Copy link
Contributor

@cheenamalhotra I'm putting this in September for consideration, I can verify that something does seem to have changed here so the filtering isn't working like it used to. That control is provided by VS Code so not a ton we can do directly about it - but it's possible there's something we're doing wrong or not doing with the tree provider that's making this happen.

(and it'd be good to know what the problem is here for ADS as well, since presumably we could have someone run into the same kind of issue there)

@whytheq
Copy link
Author

whytheq commented Jul 28, 2023

Excellent news it is being looked into. It seemed to happen around the time that Schemas became nodes in the object explorer - maybe just coincidental - just a thought.

@cheenamalhotra
Copy link
Member

cheenamalhotra commented Sep 6, 2023

Same reason as explained here: microsoft/azuredatastudio#24086 (comment)
This is external to extension, follow microsoft/vscode#66971 for updates.

@cheenamalhotra cheenamalhotra closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants