Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts not respected in notebook editor #517

Closed
jaymegordo opened this issue Oct 17, 2020 · 1 comment
Closed

Keyboard shortcuts not respected in notebook editor #517

jaymegordo opened this issue Oct 17, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@jaymegordo
Copy link

Bug: Notebook Editor, Interactive Window, Editor cells

In general, it seems a lot of the vscode global shortcuts aren't respected in the Notebook Editor.

I see in the docs that:

Ctrl+Enter runs the currently selected cell, Shift+Enter runs the currently selected cell and inserts a new cell immediately below (focus moves to new cell), and Alt+Enter runs the currently selected cell and inserts a new cell immediately below (focus remains on current cell).

In this case, I'd like to change the functionality of shift+enter to just run cell and NOT select cell below. (Large cells below will scroll the whole screen and is very disruptive).

Steps to cause the bug to occur

I've changed execute notebook cell and select below to ctrl+enter (to see if I can specifically overwrite this):

Screen Shot 2020-10-17 at 07 57 36

And set all these run cell commands to shift+enter:

Screen Shot 2020-10-17 at 08 09 12

Actual behavior

shift+enter continues to run cell and select next

Expected behavior

shift+enter runs cell WITHOUT selecting next

Your Jupyter and/or Python environment

Please provide as much info as you readily know

  • Jupyter server running: Local
  • Extension version: v2020.9.114305
  • VS Code version: 1.50.1
  • Setting python.jediEnabled: (was definitely false in the past, but just checked and this doesn't show up in settings anymore. Pylance related?)
  • Setting python.languageServer: Pylance
  • Python and/or Anaconda version: 3.7.8, 3.8.1
  • OS: Mac
  • Virtual environment: conda | pipenv

Python Output

VSCode - Python Interactive Debug Log.txt

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

@greazer
Copy link
Member

greazer commented Oct 19, 2020

Thanks for your feedback. This issue will be addressed once VS Code adds native support for editing notebooks. Please see microsoft/vscode#91987.

@greazer greazer closed this as completed Oct 19, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 11, 2020
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Nov 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

4 participants