Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using the official test suite? #102

Closed
Relequestual opened this issue Jul 19, 2021 · 6 comments · Fixed by #146
Closed

Consider using the official test suite? #102

Relequestual opened this issue Jul 19, 2021 · 6 comments · Fixed by #146
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@Relequestual
Copy link
Contributor

Hello!

Given the importance of this module when using JSON Schema, I wonder, why not use the official test suite?

I did read you don't want external dependencies. Currently we do not offer a maintained version of the test suite as an npm release. We usually suggest people use git submodules to capture the tests they need.

I do see you have tests beyond validation. The official test suite currently only covers validation.

If it's difficult to justify time to do this, I may be able to help you find some additional justification.
Making the change is beyond the time I can offer currently.

@Trias
Copy link

Trias commented Jul 20, 2021

(not the maintainer) As far as i know the module isn't in full compliance with the test suite yet. This issue seems to be the most prominent which would fail many tests of the official test suite.

@Relequestual
Copy link
Contributor Author

Thanks for linking @Trias !

The Backlog is quite small, so we can hope!

@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2021

Can you point me to the official test suite?

@aeschli aeschli added the feature-request Request for new features or functionality label Oct 25, 2021
@aeschli aeschli self-assigned this Oct 25, 2021
@aeschli aeschli added this to the Backlog milestone Oct 25, 2021
@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2021

Note that we use Backlog for all open issues, even if there are no plans to work on it. Issues worked on are marked with a milestone.

@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2021

Note that we use Backlog for all open issues, even if there are no plans to work on it. Issues worked on are marked with a Milstone.

@Relequestual
Copy link
Contributor Author

Can you point me to the official test suite?

You can find it here: https://github.com/json-schema-org/JSON-Schema-Test-Suite
Apologies for the long delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants