fix: extension debugging not working with two ipv6 interfaces #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weinand
reviewed
Jun 8, 2022
| @@ -7,6 +7,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he | |||
| - feat: simplify pretty print to align with devtools ([vscode#151410](https://github.com/microsoft/vscode/issues/151410)) | |||
| - fix: debugged child processes in ext host causing teardown ([#1289](https://github.com/microsoft/vscode-js-debug/issues/1289)) | |||
| - fix: errors thrown in process tree lookup not being visible ([vscode#150754](https://github.com/microsoft/vscode/issues/150754)) | |||
| - fix: extension debugging not working with two ipv6 interfaces ([vscode#144315](https://github.com/microsoft/vscode/issues/144315)) | |||
There was a problem hiding this comment.
is it really two ipv6 interfaces or is it a combination of ipv4 and ipv6?
There was a problem hiding this comment.
I don't think it's actually caused directly by any interface, but by some logic deciding that because there's some ipv6 interface, resolving localhost should resolve to ipv6 loopback instead of ipv4 loopback. This could, in theory, be a problem even without an ipv6 interface attached. Here though I just copied the title of the original issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode#144315