Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for indexed source maps. #1261

Merged
merged 3 commits into from
May 17, 2022
Merged

Conversation

ashgti
Copy link
Contributor

@ashgti ashgti commented May 6, 2022

Indexed source maps, described in https://sourcemaps.info/spec.html#h.535es3xeprgt this should allow users to debug bundled output, like that produced by the closure-compiler when producing bundled output.

Fixes #1260

Indexed source maps, described in https://sourcemaps.info/spec.html#h.535es3xeprgt this should allow users to debug bundled output, like that produced by the closure-compiler when producing bundled output.
@connor4312
Copy link
Member

Thanks for the PR! Can you add some test cases for these as well?

@ashgti
Copy link
Contributor Author

ashgti commented May 6, 2022

Sure, let me add a unit tests

@ashgti
Copy link
Contributor Author

ashgti commented May 6, 2022

Added new unit tests to check source map handling.

@ashgti
Copy link
Contributor Author

ashgti commented May 11, 2022

Let me know if there are any additional tests I should add

Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Thanks for the tests. The one missing thing is support for nested sections.[].urls, but I can add that in after this is merged.

@connor4312 connor4312 merged commit 7b174a0 into microsoft:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support source map files with sections ('indexed maps')
3 participants