Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve executables in node_modules/.bin directly #1984

Closed
connor4312 opened this issue Apr 3, 2024 · 1 comment · Fixed by #1985
Closed

Resolve executables in node_modules/.bin directly #1984

connor4312 opened this issue Apr 3, 2024 · 1 comment · Fixed by #1985
Assignees
@connor4312
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2024

Comments

@connor4312
Copy link
Member

connor4312 commented Apr 3, 2024 •
edited
Loading

Historically folks have had to manually do stuff like

			"program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",

Instead we should allow them to specify runtimeExecutable: "mocha" and be good to go.
@connor4312 connor4312 added the feature-request Request for new features or functionality label Apr 3, 2024
@connor4312 connor4312 added this to the April 2024 milestone Apr 3, 2024
@connor4312 connor4312 self-assigned this Apr 3, 2024
connor4312 added a commit that referenced this issue Apr 3, 2024
@connor4312
feat: resolve executables from
2067a88 
ode_modules/.bin automatically

Fixes #1984
@connor4312 connor4312 mentioned this issue Apr 3, 2024
Merged
@connor4312 connor4312 changed the title Resolve executables in node_modules/.bin direct Resolve executables in node_modules/.bin directly Apr 8, 2024
@connor4312 connor4312 added the verification-needed Verification of issue is requested label Apr 22, 2024
@andreamah andreamah added the verified Verification succeeded label Apr 24, 2024
@andreamah andreamah mentioned this issue Apr 24, 2024
Closed
@yawstrap
Copy link

yawstrap commented May 6, 2024

must support runtime template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2024
Development

Successfully merging a pull request may close this issue.

feat: resolve executables from node_modules/.bin automatically microsoft/vscode-js-debug
4 participants
@connor4312 @andreamah @yawstrap and others