Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Stack View: Include this.toString() next to method name #1770

Closed
hediet opened this issue Aug 2, 2023 · 1 comment · Fixed by #1802
Closed

Call Stack View: Include this.toString() next to method name #1770

hediet opened this issue Aug 2, 2023 · 1 comment · Fixed by #1802
Assignees
Labels
feature-request Request for new features or functionality verified Verification succeeded

Comments

@hediet
Copy link
Member

hediet commented Aug 2, 2023

For a lot of debugging situations, the method name alone is not very helpful in the call stack, especially when you have many instances of a class that interact with each other (the EventEmitter or Observable would be an example).

It would be very helpful if the call stack view would include this.toString() (or something similar) for each call frame where the this object implements toString (similar to the hover label logic).

I hacked together a quick and dirty proof of concept that gives event emitters names (which they return in their toString implementation).
With this feature, the call stack would look like this (notice _onDidChangeModelContent.fire and all the different beginUpdate call frames):

Code_-_Insiders_yU1KaweQL1

Compare this with how it is without this feature request:

oHohxBgi6E

@hediet hediet added the feature-request Request for new features or functionality label Aug 2, 2023
@connor4312 connor4312 added this to the September 2023 milestone Sep 7, 2023
connor4312 added a commit that referenced this issue Sep 13, 2023
Uses the same logic as variable preview generation.

Closes #1770
connor4312 added a commit that referenced this issue Sep 13, 2023
* feat: show class names of methods in call stack view

Uses the same logic as variable preview generation.

Closes #1770

* better formatting for static, fix test
@hediet hediet added the verified Verification succeeded label Sep 18, 2023
@hediet
Copy link
Member Author

hediet commented Sep 18, 2023

Very nice:

Code_-_Insiders_UD1L0In2he

I think this is a significant improvement of the call stack view!

I don't know if there are some toString implementation (e.g. URI.toString) that would be annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants