Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension webview debugging no longer works #1344

Closed
eamodio opened this issue Jul 26, 2022 · 3 comments · Fixed by #1356
Closed

Extension webview debugging no longer works #1344

eamodio opened this issue Jul 26, 2022 · 3 comments · Fixed by #1356
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Jul 26, 2022

I cannot get Extension webview debugging to work anymore. I don't know if it is a change in js-debug or my sourcemap generation, but no matter what I've tried to debug GitLens webviews they no longer work.

From inspecting the sourcemaps, it looks like things are right, so I think it is something in js-debug -- it looks like the absolutePath it gets for the loaded js file gets the path almost doubled up -- you can see that in the logs and I see that Debug Doctor

image

To Reproduce
Steps to reproduce the behavior:

  1. Debug GitLens
  2. Try to set a breakpoint in src/webviews/apps/home/home.ts
  3. Open the GitLens Home sidebar
  4. See that the breakpoint will not be mapped properly

Log File
vscode-debugadapter-5045641d.json.gz

VS Code Version:
Version: 1.70.0-insider (user setup)
Commit: 3cbf3063281410d21951877eb628551809d70c6b
Date: 2022-07-25T05:27:52.229Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.22622

@eamodio eamodio added the bug Issue identified by VS Code Team member as probable bug label Jul 26, 2022
connor4312 added a commit that referenced this issue Aug 3, 2022
Update to the new CDN URL, and make sure the right path resolver is used

Fixes #1344
connor4312 added a commit that referenced this issue Aug 3, 2022
Update to the new CDN URL, and make sure the right path resolver is used

Fixes #1344
@eamodio
Copy link
Contributor Author

eamodio commented Aug 4, 2022

@connor4312 👍 I didn't see a new nightly release -- should that be out soon? Dying to get this working 😄

@connor4312
Copy link
Member

Looks like there was a transient failure in the publishing pipeline, kicking a new one now...

@connor4312 connor4312 added this to the August 2022 milestone Aug 4, 2022
@eamodio
Copy link
Contributor Author

eamodio commented Aug 4, 2022

Fixed it -- thanks so much!

@connor4312 connor4312 added the verified Verification succeeded label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants