Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to debug scripts from included directories #1321

Closed
MichaelHindley opened this issue Feb 16, 2021 · 2 comments · Fixed by #1417
Closed

Unable to debug scripts from included directories #1321

MichaelHindley opened this issue Feb 16, 2021 · 2 comments · Fixed by #1417
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2022

Comments

@MichaelHindley
Copy link

  • VS Code Version: Version: 1.53.2
  • OS Version: macos catalina
  • extension version: latest

Steps to Reproduce:

  1. Create a package.json in root, one in "api" and one in "app", with any npm script.
  2. Let VScode know they exist by setting ""npm.includeDirectories": ["./api", "./app"]
  3. Notice you can see all scripts from all 3 package.json in the "run npm script" menu, but only scripts from the root package.json in the "debug npm script" menu.

Run:
image

Debug:
image
@piejanssens piejanssens mentioned this issue Apr 9, 2021
Closed
@egamma
Copy link
Member

egamma commented Jun 29, 2022

It is confusing, but the setting npm.includeDirectories is specific to the npm-scripts extension and the Javascript debugger is not aware of this.

Therefore this is a feature request against the JavaScript debugger to support debug npm script for scripts in nested folders. Please file the issue against vscode.

//CC @connor4312

@egamma egamma closed this as completed Jun 29, 2022
@connor4312 connor4312 transferred this issue from microsoft/vscode-npm-scripts Jun 29, 2022
@connor4312 connor4312 reopened this Jun 29, 2022
@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Jun 29, 2022
@connor4312 connor4312 self-assigned this Oct 6, 2022
connor4312 added a commit that referenced this issue Oct 6, 2022
@connor4312
fix: discover npm scripts in nested workspace folders
6f8681a 
Uses the (relatively) new `findFiles` API to discover all package.json's,
using the same overall logic as the built-in npm extension.

Fixes #1321
@connor4312 connor4312 mentioned this issue Oct 6, 2022
Merged
@connor4312 connor4312 added this to the October 2022 milestone Oct 6, 2022
@connor4312
Copy link
Member

There's no longer a setting, but instead the npm extension automatically discovers all package.json's. Now, we do too.

@roblourens roblourens added the verified Verification succeeded label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

fix: discover npm scripts in nested workspace folders microsoft/vscode-js-debug
4 participants
@egamma @roblourens @MichaelHindley @connor4312