feat: reload page on attached restart

Fixes #1004
microsoft · Jun 10, 2021 · c0875f1 · c0875f1
1 parent 69d988b
commit c0875f1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
 
 ## Nightly
 
+- feat: reload page on attached restart ([#1004](https://github.com/microsoft/vscode-js-debug/issues/1004))
 - fix: default F5 not working on files outside workspace ([ref](https://github.com/microsoft/vscode/issues/125796))
 - fix: debugging with no launch config fails when tsc task detection is disabled ([ref](https://github.com/microsoft/vscode/issues/69572))
 - fix: race causing lost sessions when attaching to many concurrent processes in the debug terminal ([ref](https://github.com/microsoft/vscode/issues/124060))

diff --git a/src/targets/browser/browserAttacher.ts b/src/targets/browser/browserAttacher.ts
@@ -25,6 +25,7 @@ import { VSCodeApi } from '../../ioc-extras';
 import { ITelemetryReporter } from '../../telemetry/telemetryReporter';
 import { ILaunchContext, ILauncher, ILaunchResult, IStopMetadata, ITarget } from '../targets';
 import { BrowserTargetManager } from './browserTargetManager';
+import { BrowserTargetType } from './browserTargets';
 import * as launcher from './launcher';
 
 const localize = nls.loadMessageBundle();
@@ -280,7 +281,15 @@ export class BrowserAttacher<
   }
 
   async restart(): Promise<void> {
-    // no-op
+    if (!this._targetManager) {
+      return;
+    }
+
+    for (const target of this._targetManager.targetList()) {
+      if (target.type() === BrowserTargetType.Page) {
+        target.restart();
+      }
+    }
   }
 
   targetList(): ITarget[] {

diff --git a/src/targets/browser/browserTargetManager.ts b/src/targets/browser/browserTargetManager.ts
@@ -12,7 +12,6 @@ import { AnyChromiumConfiguration } from '../../configuration';
 import { IBrowserVersionMetrics } from '../../telemetry/classification';
 import { ITelemetryReporter } from '../../telemetry/telemetryReporter';
 import { ITargetOrigin } from '../targetOrigin';
-import { ITarget } from '../targets';
 import { BrowserTarget, BrowserTargetType, domDebuggerTypes, jsTypes } from './browserTargets';
 import { FrameModel } from './frames';
 import { ServiceWorkerModel } from './serviceWorkers';
@@ -87,7 +86,7 @@ export class BrowserTargetManager implements IDisposable {
     this.serviceWorkerModel.dispose();
   }
 
-  targetList(): ITarget[] {
+  targetList() {
     return Array.from(this._targets.values()).filter(target => jsTypes.has(target.type()));
   }