Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exec form of the CMD Dockerfile command in files we scaffold #2090

Closed
karolz-ms opened this issue Jun 21, 2020 · 2 comments · Fixed by #2172
Closed

Use exec form of the CMD Dockerfile command in files we scaffold #2090

karolz-ms opened this issue Jun 21, 2020 · 2 comments · Fixed by #2172

Comments

@karolz-ms
Copy link
Contributor

karolz-ms commented Jun 21, 2020

This is Docker best practice https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#cmd that ensures signals are properly delivered to the main container process and eliminates shell dependency

#2089 highlighted a problem in the Node.js Dockerfiles; there might be other places that need changing

@bwateratmsft
Copy link
Contributor

bwateratmsft commented Jul 15, 2020

Looking at the code, we already do this form for Python, CPP, and Ruby. I think only Node and Other need to be changed. Other may not justify it since it is meant as no more than placeholder code to begin with.

@bwateratmsft bwateratmsft self-assigned this Jul 15, 2020
@bwateratmsft bwateratmsft removed their assignment Jul 20, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 31, 2020
@bwateratmsft
Copy link
Contributor

This has been fixed in Docker extension version 1.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants