Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to a tasks-based model for Docker Build / Docker Run #1242

Closed
bwateratmsft opened this issue Sep 3, 2019 · 0 comments · Fixed by #1245
Closed

Change to a tasks-based model for Docker Build / Docker Run #1242

bwateratmsft opened this issue Sep 3, 2019 · 0 comments · Fixed by #1245

Comments

@bwateratmsft
Copy link
Contributor

bwateratmsft commented Sep 3, 2019

Historically the process of building and starting a debug container was done entirely during resolveDebugConfiguration, which at the time was the only way possible, but is a bit of an abuse of the API.

Now that resolveTask is supported in VSCode, it is possible for us to resolve docker build / docker run tasks just-in-time. This means we can use preLaunchTask + tasks to start the container for debugging.

In addition this gives us an opportunity to add debuggable languages/platforms more easily. Our top three appear to be Node.js, .NET Core, and Python.

This PR also enhances the previously-existing build command to use an available docker-build task from tasks.json, otherwise it falls back to the prior behavior.

This PR also adds a pull option to docker build options, equivalent to the --pull flag, to help mitigate issues caused by stale images.

Related items:
#764
#879
#38
#1094
#1211
#1202

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants