Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in menu #9204

Closed
PawelGPL opened this issue Feb 18, 2021 · 10 comments
Closed

Error in menu #9204

PawelGPL opened this issue Feb 18, 2021 · 10 comments
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.6

Comments

@PawelGPL
Copy link

I noticed a small error on the menu: in item "Settings" there is "Ctrl Alt ," shortcut instead of "Ctrl ," (open settings.json).

Environment

Microsoft Windows Version 10.0.19042.804

Steps to reproduce

Expected behavior

Actual behavior
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 18, 2021
@zadjii-msft
Copy link
Member

Can you share your settings.json? Also, what keyboard layout are you using?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 18, 2021
@PawelGPL
Copy link
Author

Default settings.json. It does not matter. Even after deleting this file there is the mentioned error in the menu. Clicking on a menu item works like shortcut "Ctrl ," not like "Ctrl Alt ,".
obraz

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 18, 2021
@zadjii-msft
Copy link
Member

@PawelGPL What keyboard layout are you using? Do you need to press the AltGr key to type the , character?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 18, 2021
@PawelGPL
Copy link
Author

PawelGPL commented Feb 18, 2021 •
edited
Loading

I don't need to use Alt or AltGr to type , (comma).

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 18, 2021
@zadjii-msft
Copy link
Member

Hmm. Something weird is going on here.

#8967 reminded me that we actually do bind that keybinding by default:

  { "command": "openSettings", "keys": "ctrl+," },
  { "command": { "action": "openSettings", "target": "defaultsFile" }, "keys": "ctrl+alt+," },

But not to open the settings file - it's bound to opening the defaults file.

  • What version of the terminal are you using?
  • What keyboard layout are you using?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 18, 2021
@PawelGPL
Copy link
Author

I have current version - 1.53.2
I have exactly the same setting in default.json
I'm using US keyboard with specific Polish characters obtained by pressing with AltGr, e.g AltGr-c -> ć.
All works ok. except wrong description in menu:
Ctrl+, opens settings.json just like clicking in Settings in menu
Ctrl+Atl+, opens defaults.json

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 18, 2021
@zadjii-msft
Copy link
Member

Son of a gun they'll do it. If you paste that action:

  { "command": { "action": "openSettings", "target": "defaultsFile" }, "keys": "ctrl+alt+," },

into the actions on 1.5, it'll use that one as the help shortcut to use, not the actual settings action. I think that's already fixed on 1.6, but I don't know when or where we fixed that. We might have a dupe somewhere...

@PawelGPL

This comment has been minimized.

Sign in to view
@DHowett

This comment has been minimized.

Sign in to view
@zadjii-msft
Copy link
Member

Alright, so looking through the history, I think this was broken in (the combo of #7802 and #8725) and was fixed in #8670. That PR didn't have an original issue tracking it, but rest assured, this is already fixed ☺️

@zadjii-msft zadjii-msft added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 18, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.6 milestone Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.6
Development

No branches or pull requests
3 participants
@DHowett @zadjii-msft @PawelGPL