Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light schemes are unusable: bold text is white #6283

Closed
mscha opened this issue May 31, 2020 · 6 comments
Closed

Light schemes are unusable: bold text is white #6283

mscha opened this issue May 31, 2020 · 6 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@mscha
Copy link

mscha commented May 31, 2020

Environment

Windows build number: 10.0.19041.264
Windows Terminal version (if applicable): 1.0.1401.0

Any other software?

Steps to reproduce

Configure a WSL profile to use a light color scheme, e.g. Solarized Light.
Open that profile.
Output some bold text, e.g.:

echo `tput bold`Hello`tput sgr0` World

Expected behavior

Ideally, the output should be:
Hello World
with “Hello” in bold. But as long as bold fonts are not supported, it should be emphasized using a slightly different color.

Actual behavior

The word “Hello” is white, and therefore basically invisible. “World” is written in the standard text color.

The “bold color” logic currently assumes that white is a reasonable “bold” color for the standard text color. This might be true on most dark schemes, but not on light schemes.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 31, 2020
@fishfacemcgee
Copy link

fishfacemcgee commented Jun 3, 2020

There are similar readability issues on Solarized Dark, too:

Solarized Dark:

image

The same text on Solarized Light:

image

@Artoria2e5
Copy link

Artoria2e5 commented Jun 3, 2020

This is related to #109. Instead of turning bold into the bright colors, they should have a (default, IMO) option for actual bold text. There's also missing support for italics, underline, etc.


Yeah, @jdebp's wonderful tests now show good underline. The 8-bit one works under 65001; the Unicode one with forced UTF-8 was never supposed to work I guess.

@DHowett
Copy link
Member

DHowett commented Jun 3, 2020

image

but your point stands

@j4james
Copy link
Collaborator

j4james commented Jun 5, 2020

I think this particular issue is more a duplicate of #5682. Regardless of whether we add support for a bold font face, our handling of bright default colors could do with some work. That could include making use of the bold color when the color scheme provides one, or a fallback that just fabricates a brighter version of the default foreground color. At the moment the bright default combo only works if the default color matches one of the first 8 palette entries.

@zadjii-msft
Copy link
Member

Yea, this largely seems like it's discussion that's better suited in #5682. Thanks all!

/dup #5682

@ghost
Copy link

ghost commented Jun 5, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jun 5, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 5, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

6 participants