-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light schemes are unusable: bold text is white #6283
Comments
This is related to #109. Instead of turning bold into the bright colors, they should have a (default, IMO) option for actual bold text. There's also missing support for italics, Yeah, @jdebp's wonderful tests now show good underline. The 8-bit one works under 65001; the Unicode one with forced UTF-8 was never supposed to work I guess. |
I think this particular issue is more a duplicate of #5682. Regardless of whether we add support for a bold font face, our handling of bright default colors could do with some work. That could include making use of the bold color when the color scheme provides one, or a fallback that just fabricates a brighter version of the default foreground color. At the moment the bright default combo only works if the default color matches one of the first 8 palette entries. |
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
Environment
Steps to reproduce
Configure a WSL profile to use a light color scheme, e.g. Solarized Light.
Open that profile.
Output some bold text, e.g.:
Expected behavior
Ideally, the output should be:
Hello World
with “Hello” in bold. But as long as bold fonts are not supported, it should be emphasized using a slightly different color.
Actual behavior
The word “Hello” is white, and therefore basically invisible. “World” is written in the standard text color.
The “bold color” logic currently assumes that white is a reasonable “bold” color for the standard text color. This might be true on most dark schemes, but not on light schemes.
The text was updated successfully, but these errors were encountered: