Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] New Profile -> with Split view? #5328

Closed
martinandersen3d opened this issue Apr 12, 2020 · 7 comments
Closed

[Feature] New Profile -> with Split view? #5328

martinandersen3d opened this issue Apr 12, 2020 · 7 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@martinandersen3d
Copy link

Description of the new feature/enhancement

I would like some way to define a Profile, where splitscreen is allready defined. How can we do this best?

Or is it allready in there?

Proposed technical implementation details (optional)

image

What would the syntax be? :)

@martinandersen3d martinandersen3d added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 12, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 12, 2020
@zadjii-msft
Copy link
Member

Out of curiosity, when you open a new tab with this profile, what do you expect to happen? Does it automatically create two panes, split vertically, with this profile? Does it create two panes, one with the default profile, and another with the given profile?

It seems to me like you're looking for the ability to open a pane with a specific profile. I personally use the following keybindings to great success:

        { "keys": [ "ctrl+alt+t" ], "command": { "action": "splitPane", "split":"auto", "splitMode": "duplicate" }  },
        { "keys": [ "ctrl+alt+z" ], "command": { "action": "splitPane", "profile": "Ubuntu 18.04", "split":"auto" } },
  • ctrl+alt+t Opens a new split with the current profile, with either a vertical or horizontal split (whichever gives it the most space)
  • ctrl+alt+z Opens a new split with my "Ubuntu 18.04" profile, with either a vertical or horizontal split (whichever gives it the most space)

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Apr 13, 2020
@jdhitsolutions
Copy link

jdhitsolutions commented Apr 16, 2020

I was just trying to figure out how to do this. Keybindings are fine, if I can remember what they are. I too would like an ability to define a profile with assigned split sections. Or let me run a WT command line that will open what I want in the existing WT instance.

@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Apr 20, 2020
@ghost
Copy link

ghost commented Apr 20, 2020

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@jdhitsolutions
Copy link

I guess I'll speak for the original poster. I guess I'd like to see profile syntax that lets me specify an array of split panels including whether it is horizontal or vertical. It other words, the profile setting becomes an array of sub-panels. Maybe something like this:

   "profiles": [
        {
                "tabTitle": "PowerShell Panels",
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "panels": [
                    {
                    "acrylicOpacity": 0.5,
                    "background": "#012456",
                    "closeOnExit": true,
                    "colorScheme": "Campbell",
                    "commandline": "powershell.exe -nologo",
                    "split": "horizontal",
                    "cursorColor": "#FFFFFF",
                    "cursorShape": "bar",
                    "fontFace": "Consolas",
                    "fontSize": 14,
                    "historySize": 9001,
                    "icon": "ms-appx:/// ProfileIcon s/{61c54bbd-c2c6-5271-96e7-009a87ff44bf}.png",
                    "name": "Windows PowerShell",
                    "padding": "0, 0, 0, 0",
                    "snapOnInput": true,
                    "startingDirectory": "%USERPROFILE%",
                    "useAcrylic": false
                },
                {
                    "acrylicOpacity": 0.5,
                    "background": "#012456",
                    "closeOnExit": true,
                    "colorScheme": "Campbell",
                    "commandline": "pwsh -nologo",
                    "split": "auto",
                    "cursorColor": "#FFFFFF",
                    "cursorShape": "bar",
                    "fontFace": "Consolas",
                    "fontSize": 14,
                    "historySize": 9001,
                    "name": "Windows PowerShell",
                    "padding": "0, 0, 0, 0",
                    "snapOnInput": true,
                    "startingDirectory": "%USERPROFILE%",
                    "useAcrylic": false
                }
                ]
        }
    ]

I slapped a few things together for the mock up. If I have to go to the effort of adding in the keyboard shortcuts, I might as well be able to edit settings to define a custom layout.

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Apr 20, 2020
@martinandersen3d
Copy link
Author

Yes I agree. It needs to be customisable to every individual persons needs 😉

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 20, 2020
@DHowett-MSFT
Copy link
Contributor

So, it turns out this is called out from #4632, the commandline scenario!

Add support for a profile to launch multiple panes using wt commands
Add support for running a set of wt commands on startup

I think the "ideal" way forward is to slowly deprecate (never kill!) defaultProfile and replace it with startupCommands or something similar, to let you specify "on startup, or on a profile launch, do new-tab;split-pane;split-pane;focus-tab -1"

I'm gonna mark this one, for now, as a /dup of #4632. Further discussion to follow -- let's get on that megathread and tease out some details.

@DHowett-MSFT DHowett-MSFT added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered and removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 1, 2020
@ghost
Copy link

ghost commented May 1, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants