Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in line wrapping from #2924 #3052

Closed
DHowett-MSFT opened this issue Oct 4, 2019 · 1 comment · Fixed by #3212
Closed

Regression in line wrapping from #2924 #3052

DHowett-MSFT opened this issue Oct 4, 2019 · 1 comment · Fixed by #3212
Assignees
@DHowett-MSFT @miniksa
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal-1910

Comments

@DHowett-MSFT
Copy link
Contributor

When you get to the end of a line in Terminal, it now disagrees with conhost as to where the next line goes.

Terminal:

aaaaaaaaaa|
          |
aaaa      |

Conhost:

aaaaaaaaaa|
aaaa      |

Possible regression from #2924.
@DHowett-MSFT DHowett-MSFT added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Priority-1 A description (P1) labels Oct 4, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal-1910 milestone Oct 4, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 4, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 8, 2019
@sc0ttwad3 sc0ttwad3 mentioned this issue Oct 9, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 10, 2019
Closed
@skyline75489 skyline75489 mentioned this issue Oct 13, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 15, 2019
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 15, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 16, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

🎉This issue was addressed in #3212, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.:tada:

Handy links:

@Jkoutsoumpas Jkoutsoumpas mentioned this issue Nov 4, 2019
Closed
@zadjii-msft zadjii-msft mentioned this issue Jan 8, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

@miniksa miniksa

Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal-1910
Development

Successfully merging a pull request may close this issue.

Revert "Patch fix for #1360 (#2924)" microsoft/terminal
2 participants
@DHowett-MSFT @miniksa