Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report - Crash due to unhandled exception in Microsoft::Console::Render::Renderer::_PaintBufferOutputHelper #2778

Closed
Treit opened this issue Sep 16, 2019 · 2 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@Treit
Copy link

Treit commented Sep 16, 2019

Here is the feedback link I filed:
Feedback

Environment

Windows version 10.0.18970.0.
Latest Windows Terminal build (either the available bits or locally built.)

Steps to reproduce

This is the same repro as issue 1360, which I was trying to reproduce and hit this render-related crash instead:

Install ripgrep
Open wt (Windows Terminal), running PowerShell.
Run the following from the root of a large drive
while ($true) { rg -i "foo" }

Expected behavior

The terminal continually runs ripgrep against all files on the drive. It does not crash.

Actual behavior

Eventually the process will crash. If running a debug build, you will get an Assert dialog (Abort, Retry, Ignore) and if you attach a debugger and press Retry you will see the crash is in renderer.cpp at line 642:

STACK_TEXT:
000000058cefd950 00007ffed69d4f99 KERNELBASE!RaiseException+0x69
000000058cefda30 00007ffe9f018337 VCRUNTIME140D!_CxxThrowException+0x137
000000058cefdae0 00007ffe4181ec63 TerminalControl!wil::details::ThrowResultExceptionInternal+0x53
000000058cefdbe0 00007ffe4181ebe9 TerminalControl!wil::ThrowResultException+0x49
000000058cefdc20 00007ffe4181cd85 TerminalControl!wil::details::ReportFailure+0x1e5
000000058ceff1d0 00007ffe4181d131 TerminalControl!wil::details::ReportFailure_Hr+0x91
000000058ceff230 00007ffe41827084 TerminalControl!wil::details::in1diag5::_Throw_Hr+0x74
000000058ceff280 00007ffe418a6e59 TerminalControl!wil::details::in1diag5::Throw_IfFailed+0x69
000000058ceff2c0 00007ffe4193ea77 TerminalControl!Microsoft::Console::Render::Renderer::_PaintBufferOutputHelper+0x3f7
000000058ceff4b0 00007ffe4193e5f4 TerminalControl!Microsoft::Console::Render::Renderer::_PaintBufferOutput+0x394
000000058ceff750 00007ffe4193dd57 TerminalControl!Microsoft::Console::Render::Renderer::_PaintFrameForEngine+0x487
000000058ceff8c0 00007ffe4193bf95 TerminalControl!Microsoft::Console::Render::Renderer::PaintFrame+0xf5
000000058ceff980 00007ffe4193b84a TerminalControl!Microsoft::Console::Render::RenderThread::_ThreadProc+0x8a
000000058ceff9c0 00007ffe4193b7a6 TerminalControl!Microsoft::Console::Render::RenderThread::s_ThreadProc+0x46
000000058ceffa00 00007ffed82c7034 KERNEL32!BaseThreadInitThunk+0x14
000000058ceffa30 00007ffed8ddb1b1 ntdll!RtlUserThreadStart+0x21

FAULTING_SOURCE_FILE: E:\src\git\Terminal\src\renderer\base\renderer.cpp
FAULTING_SOURCE_LINE_NUMBER: 642
SYMBOL_NAME: TerminalControl!Microsoft::Console::Render::Renderer::_PaintBufferOutputHelper+3f7

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 16, 2019
@DHowett-MSFT
Copy link
Contributor

/dup #2724

@ghost
Copy link

ghost commented Sep 16, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Sep 16, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 16, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants